Skip to content

Logger support#2657

Merged
solnic merged 12 commits intomasterfrom
2644-logger-support
Jun 26, 2025
Merged

Logger support#2657
solnic merged 12 commits intomasterfrom
2644-logger-support

Conversation

@solnic
Copy link
Copy Markdown
Collaborator

@solnic solnic commented Jun 24, 2025 •
edited
Loading

This builds on #2653.

I had to isolate specs because we can't patch logger while running the whole spec suite.

#skip-changelog

@solnic solnic linked an issue Jun 24, 2025 that may be closed by this pull request
Logger support #2644
Closed
@solnic solnic mentioned this pull request Jun 24, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (32ca39e) to head (cdf0ad8).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
+ Coverage   96.98%   97.48%   +0.49%     
==========================================
  Files         133      134       +1     
  Lines        5147     5167      +20     
==========================================
+ Hits         4992     5037      +45     
+ Misses        155      130      -25
Components Coverage Δ
sentry-ruby 97.73% <100.00%> (+0.26%) ⬆️
sentry-rails 96.70% <ø> (+1.79%) ⬆️
sentry-sidekiq 96.57% <ø> (+1.14%) ⬆️
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 99.14% <100.00%> (+<0.01%) ⬆️
sentry-ruby/lib/sentry/std_lib_logger.rb 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic
Copy link
Copy Markdown
Collaborator Author

solnic commented Jun 24, 2025

OK I need to rework this because there are issues with the spec suite as testing is not isolated and patching obviously changes runtime. Right now it gets to a state that would normally be very unlikely to have where the patch is applied but enable_logs is disabled, causing Sentry.logger to be no longer StructuredLogger but the sdk logger which inherits from Logger...leading to stack call errors. Fun! :)

@solnic solnic force-pushed the 2644-logger-support branch from cca089a to 0121c8c Compare June 25, 2025 12:27
@solnic solnic marked this pull request as ready for review June 25, 2025 12:33
@solnic solnic requested a review from sl0thentr0py June 25, 2025 12:33
@solnic
Copy link
Copy Markdown
Collaborator Author

solnic commented Jun 25, 2025

@sl0thentr0py ignore head failures, something is messed up with bundling rn 🤷🏻

@solnic solnic mentioned this pull request Jun 25, 2025
Closed
sl0thentr0py
sl0thentr0py approved these changes Jun 25, 2025
View reviewed changes
sentry-ruby/spec/isolated/sentry_logger_spec.rb
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs a SimpleCov.command_name since it is now isolated

@solnic solnic merged commit eeaeb2a into master Jun 26, 2025
264 of 270 checks passed
@solnic solnic deleted the 2644-logger-support branch June 26, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logger support

3 participants

@solnic @sl0thentr0py @Eazybright