Optimize LogEvent to reduce memory consumption#2643
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
==========================================
+ Coverage 93.68% 96.70% +3.01%
==========================================
Files 133 133
Lines 5101 5131 +30
==========================================
+ Hits 4779 4962 +183
+ Misses 322 169 -153
🚀 New features to boost your workflow:
|
09006fa to
ecfe433
Compare
sl0thentr0py
approved these changes
Jun 10, 2025
dentarg
reviewed
Jun 30, 2025
sentry-ruby/lib/sentry/log_event.rb
Outdated
| { value: value, type: value_type(value) } | ||
| end | ||
|
|
||
| VALUE_TYPES = Hash.new("string").merge!({ |
Contributor
There was a problem hiding this comment.
Gotta be careful when using the default value
$ irb
irb(main):001> a = Hash.new("string")
=> {}
irb(main):002> a["foo"]
=> "string"
irb(main):003> a["bar"] << "bar"
=> "stringbar"
irb(main):004> a["foo"]
=> "stringbar"
Collaborator
Author
There was a problem hiding this comment.
@dentarg @sl0thentr0py I believe we're good since there's frozen string literals magic comment at the top of this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current status
Closes #2641