Don't log warnings about missing deps when profiling is not enabled#2542
Merged
sl0thentr0py merged 2 commits intomasterfrom Feb 5, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2542 +/- ##
==========================================
- Coverage 69.40% 69.34% -0.06%
==========================================
Files 126 126
Lines 4723 4727 +4
==========================================
Hits 3278 3278
- Misses 1445 1449 +4
|
sl0thentr0py
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up after #2537
I really tried to do it without introducing a new method but it was hopeless. I also think we need a robust mechanism for checking if a 3rd party dep is present and this is the first step in that direction.
Refs #2534