Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
- Coverage 69.78% 69.32% -0.46%
==========================================
Files 125 125
Lines 4719 4721 +2
==========================================
- Hits 3293 3273 -20
- Misses 1426 1448 +22
|
It is an overkill to have a (implicit) dependency on fugit, especially that it doesn't even offer a public interface to do what we need. It's older version don't support timezones in cron which I believe is the culprit in #2513. Even if it's not, I still think it's a good change.
fccf7f0 to
33835f3
Compare
sl0thentr0py
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is an overkill to have a (implicit) dependency
on fugit, especially that it doesn't even offer
a public interface to do what we need.
It's older version don't support timezones in cron which I believe is the culprit in #2513.
Even if it's not, I still think it's a good change.