Test Ruby 3.4; Upgrade actions workflows versions#2506
Merged
solnic merged 4 commits intogetsentry:masterfrom Jan 2, 2025
Merged
Test Ruby 3.4; Upgrade actions workflows versions#2506solnic merged 4 commits intogetsentry:masterfrom
solnic merged 4 commits intogetsentry:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
- Coverage 98.20% 98.18% -0.02%
==========================================
Files 128 128
Lines 4837 4839 +2
==========================================
+ Hits 4750 4751 +1
- Misses 87 88 +1
|
solnic
approved these changes
Jan 2, 2025
Collaborator
solnic
left a comment
There was a problem hiding this comment.
Thank you! We need to support ancient Rubies as long as Sentry customers use them 😅
Contributor
Author
|
To be fair, as long as it's not an excessive work, it's fine! We have a 2.7.x app running as well😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes:
Upgrades tons of actions/checkout@v1 to v4, add 3.4 to build matrix.
Other questions: Ruby 2.4 is supported and tested, although it's EOL since 2020. Same goes for all versions through 3.0 actually, in yearly increments.
I'm all for keeping the test suite including some EOL versions, but 2.4 seems excessive.