Skip to content

feat: Remove usage of user segment#2493

Closed
AbhiPrasad wants to merge 2 commits intomasterfrom
abhi-deprecate-user-segment
Closed

feat: Remove usage of user segment#2493
AbhiPrasad wants to merge 2 commits intomasterfrom
abhi-deprecate-user-segment

Conversation

@AbhiPrasad
Copy link
Copy Markdown
Contributor

ref getsentry/team-sdks#44

user segment has been deprecated across all the sdks, and was never used for dynamic sampling logic, so it's safe to remove.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b99d0d1

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (d8c1066) to head (b99d0d1).
Report is 74 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2493      +/-   ##
==========================================
- Coverage   98.19%   98.19%   -0.01%     
==========================================
  Files         128      128              
  Lines        4833     4832       -1     
==========================================
- Hits         4746     4745       -1     
  Misses         87       87              
Components Coverage Δ
sentry-ruby 98.67% <ø> (+0.05%) ⬆️
sentry-rails 96.50% <ø> (+0.37%) ⬆️
sentry-sidekiq 97.42% <ø> (ø)
sentry-resque 95.50% <ø> (-0.83%) ⬇️
sentry-delayed_job 95.83% <ø> (-4.17%) ⬇️
sentry-opentelemetry ∅ <ø> (∅)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/propagation_context.rb 100.00% <ø> (ø)
sentry-ruby/lib/sentry/transaction.rb 99.35% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AbhiPrasad AbhiPrasad force-pushed the abhi-deprecate-user-segment branch from 07d259e to b99d0d1 Compare December 12, 2024 16:49
@AbhiPrasad AbhiPrasad closed this Mar 18, 2025
@AbhiPrasad AbhiPrasad deleted the abhi-deprecate-user-segment branch March 18, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant