Fix error events missing a DSC when there's an active span#2408
Merged
sl0thentr0py merged 1 commit intomasterfrom Sep 19, 2024
Merged
Fix error events missing a DSC when there's an active span#2408sl0thentr0py merged 1 commit intomasterfrom
sl0thentr0py merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2408 +/- ##
==========================================
- Coverage 98.69% 98.68% -0.01%
==========================================
Files 210 210
Lines 13922 13935 +13
==========================================
+ Hits 13740 13752 +12
- Misses 182 183 +1
|
51e4b1d to
57e979b
Compare
cleptric
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were actually missing the DSC in the envelope header in the case when we have a non-transaction event (like an error) being sent but with an active span/transaction on the scope.
fixes #2400