Conversation
Instead of falling back to the default app dirs pattern when `config.app_dirs_pattern` is `nil`, we can simply set it to `APP_DIRS_PATTERN` by default. This means we don't need to always check if `config.app_dirs_pattern` is set and can simply use it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
- Coverage 98.69% 98.68% -0.01%
==========================================
Files 210 210
Lines 13923 13923
==========================================
- Hits 13741 13740 -1
- Misses 182 183 +1
|
sl0thentr0py
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of falling back to the default app dirs pattern when
config.app_dirs_patternisnil, we can simply set it toAPP_DIRS_PATTERNby default.This means we don't need to always check if
config.app_dirs_patternis set and can simply use it.