Improve sidekiq-cron patch#2387
Merged
sl0thentr0py merged 2 commits intogetsentry:masterfrom Aug 27, 2024
adamzapasnik:sidekiq-cron-patches
Merged
Improve sidekiq-cron patch#2387sl0thentr0py merged 2 commits intogetsentry:masterfrom adamzapasnik:sidekiq-cron-patches
sl0thentr0py merged 2 commits intogetsentry:masterfrom
adamzapasnik:sidekiq-cron-patches
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
- Coverage 98.70% 98.68% -0.02%
==========================================
Files 210 210
Lines 13904 13923 +19
==========================================
+ Hits 13724 13740 +16
- Misses 180 183 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes:
I've added two changes:
1st
name.to_scause one may provide hash with symbols toload_from_hashandnameends up being a symbol, and then it ends up raising an error insentry-ruby/lib/sentry/hub.rbcause it expects a string...2nd change is much more important though, it's required to support natural-language-format, because the current version doesn't create a monitor successfully. natural language format is something like
every 5 minuteswhich gets translated to'*/5 * * * *'as you can see it in the testshttps://github.com/sidekiq-cron/sidekiq-cron?tab=readme-ov-file#natural-language-formats