Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
===========================================
+ Coverage 78.10% 98.70% +20.60%
===========================================
Files 149 209 +60
Lines 7011 13861 +6850
===========================================
+ Hits 5476 13682 +8206
+ Misses 1535 179 -1356
|
This makes it possible to use rubocop when working from inside a subdir. It also fixes running rubocop from the root where it would actually use the config that we have. Previously it would ignore it for some reason, symlinking did the trick. The rubocop-packaging was needed because something somewhere tries to require it.
d85c58c to
be3764a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to use rubocop when working from inside a subdir.
It also fixes running rubocop from the root where it would actually use
the config that we have. Previously it would ignore it for some reason,
symlinking did the trick.
The rubocop-packaging was needed because something somewhere tries to
require it.
#skip-changelog