feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT#2374
Merged
sl0thentr0py merged 12 commits intogetsentry:masterfrom Aug 16, 2024
BYK:byk/feat/SENTRY_DEBUG_and_SENTRY_SPOTLIGHT
Merged
feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT#2374sl0thentr0py merged 12 commits intogetsentry:masterfrom BYK:byk/feat/SENTRY_DEBUG_and_SENTRY_SPOTLIGHT
sl0thentr0py merged 12 commits intogetsentry:masterfrom
BYK:byk/feat/SENTRY_DEBUG_and_SENTRY_SPOTLIGHT
Conversation
added 8 commits
August 15, 2024 14:32
Part of getsentry/spotlight#482. Similar to sentry-python#3443 but it also adds support for `$SENTRY_DEBUG` which was lacking in the Ruby SDK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2374 +/- ##
===========================================
+ Coverage 78.10% 98.71% +20.61%
===========================================
Files 149 210 +61
Lines 7011 13904 +6893
===========================================
+ Hits 5476 13726 +8250
+ Misses 1535 178 -1357
|
Member
Author
|
Astonished that it only took me like 5 tries to get it right 🤣 |
sl0thentr0py
requested changes
Aug 16, 2024
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
I would like a couple of tests in spotlight_transport_spec.rb but if you don't wanna figure out rspec I can also take care of that, lmk
Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
sl0thentr0py
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of getsentry/spotlight#482. Similar to getsentry/sentry-python#3443 but it also adds support for
$SENTRY_DEBUGwhich was lacking in the Ruby SDK.