Experimental support for multi-threaded profiling using Vernier#2372
Merged
sl0thentr0py merged 21 commits intomasterfrom Oct 4, 2024
Merged
Experimental support for multi-threaded profiling using Vernier#2372sl0thentr0py merged 21 commits intomasterfrom
sl0thentr0py merged 21 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2372 +/- ##
==========================================
- Coverage 98.68% 98.66% -0.03%
==========================================
Files 211 218 +7
Lines 13987 14337 +350
==========================================
+ Hits 13803 14145 +342
- Misses 184 192 +8
|
3d995d8 to
b45c7f3
Compare
5220e97 to
bd687cc
Compare
sl0thentr0py
requested changes
Aug 27, 2024
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
amazing work @solnic
did a first pass, some questions and comments
will do a detailed test round later in the week
st0012
reviewed
Aug 30, 2024
st0012
reviewed
Aug 30, 2024
579dfef to
babc6ed
Compare
Collaborator
Author
|
@sl0thentr0py @st0012 thanks for the comments! There are a couple of things that need be fixed. I'll ping you once it's done next week. |
6cc823c to
3a9367b
Compare
4d2785b to
dd7fdf9
Compare
b22bd63 to
97e21ac
Compare
Member
|
we need to generalize this logic to have different limits according to different envelope |
Seems like StackProf.results is leaking between specs when it's stubbed via `allow`, so we gotta restub it in the profiler spec too.
- Introduce `Sentry::Vernier::Profiler` - Introduce `Sentry.config.profiler` that can be set to a class that should be used for profiling. By default it's set to `Sentry::Profiler`
282c3c2 to
0e1fde8
Compare
Collaborator
Author
|
@sl0thentr0py alright this is now using the increased envelope profile item limit |
Member
|
omg the profiles look perfect <3 |
sl0thentr0py
approved these changes
Oct 4, 2024
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
incredible work!!! so happy to ship this
Collaborator
Author
|
@sl0thentr0py yessssss! Thanks for the reviews and testing! Let's 🚢 it 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental support for Vernier.
Screenshots