Support for tracing Faraday requests#2345
Merged
sl0thentr0py merged 6 commits intomasterfrom Jul 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
+ Coverage 98.66% 98.68% +0.01%
==========================================
Files 205 207 +2
Lines 13559 13741 +182
==========================================
+ Hits 13378 13560 +182
Misses 181 181
|
Member
|
looks great so far! as you noted in the description, you need to further
|
sl0thentr0py
requested changes
Jul 23, 2024
bab2bac to
295cf2e
Compare
Collaborator
Author
|
@sl0thentr0py http patch is one of the default ones, which means we should skip setting up faraday patch if its adapter is net/http - does this make sense? |
Member
|
@solnic yes please! |
solnic
commented
Jul 24, 2024
fe10b09 to
14e3e1d
Compare
14e3e1d to
037e5cf
Compare
sl0thentr0py
requested changes
Jul 25, 2024
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
great first PR @solnic!
just a few nits and comments
sl0thentr0py
approved these changes
Jul 26, 2024
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
perfect, ty and grats on landing your first PR!
Collaborator
Author
|
Ahh yes! Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for automatic tracing of HTTP requests when using Faraday. It leverages its instrumentation middleware to do the magic.
Todo
Add a Sentry middleware that will set everything upturned out we needed a monkeypatch after all(optional/stretch) unify implementation between net/http MP and faraday extensionif we decide to do it, it should go to a separate PRCloses #1795