Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2342 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 205 205
Lines 13488 13493 +5
=======================================
+ Hits 13308 13313 +5
Misses 180 180
|
sl0thentr0py
approved these changes
Jul 23, 2024
|
@st0012 I don't think that the
Also, this PR does not fix the issue that #2051 describes: I suggest the issue be reopened or closed as "won't fix" and this PR be reverted. I filed a bug report just in case you agree after some consideration. Feel free to close if you disagree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2051
When resetting the test environment with the
teardown_sentry_testhelper, global event processors should be cleared too.(I also made sentry-ruby's tests not fail fast as they're quite flaky at times due to dependencies, request issues...etc.)