Ignore Sidekiq::JobRetry::Handled exception#2337
Merged
solnic merged 3 commits intogetsentry:masterfrom Jan 2, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2337 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 126 126
Lines 4723 4723
=======================================
Hits 4633 4633
Misses 90 90
|
|
+1. I have a bunch of these in my Sentry as well, and they're always next to a second error event that's the actual problem. They can be safely ignored. |
ebe45e4 to
c3776b4
Compare
solnic
approved these changes
Jan 2, 2025
Collaborator
solnic
left a comment
There was a problem hiding this comment.
This makes sense. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Sidekiq::JobRetry::Handledexception to default Sidekiq ignore list.Sidekiq::JobRetry::Skipexceptions are currently ignored, however, since Sidekiq 7.3.0 shipped, I thinkSidekiq::JobRetry::Handledexceptions also need to be ignored.You can see the full diff between 7.2.4..7.3.0 and I'd particularly like to draw your attention to the changes within
lib/sidekiq/job_retry.rb.You can see in certain scenarios Sidekiq now raises
Sidekiq::JobRetry::Handled(7.3.0) instead ofSidekiq::JobRetry::Skip(7.2.4).Without this change, some customers will see the following in their Sentry Issues after upgrading to Sidekiq 7.3.0.