Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2335 +/- ##
==========================================
+ Coverage 98.66% 98.67% +0.01%
==========================================
Files 205 205
Lines 13481 13479 -2
==========================================
Hits 13301 13301
+ Misses 180 178 -2
|
This will break users with bundler standalone setup.
|
@sl0thentr0py working with older Rubies, especially those <= 2.5, has been increasingly frustrating. Is there any plan to ditch support for them? |
|
We can do it in the major, maybe I should do the major soon with dropping async and related stuff. The large hub refactor is postponed for now. |
FWIW, dropping a dependency/language version isn't usually considered a breaking change because in that case, the user simply won't install that version onwards. |
|
I've had all kinds of problems in CI etc because someone dropped language support in a minor, just cleaner to do it in a major |
Fixes #2329
I also needed to bump
sqlite3becausev1.6.9doesn't run on Ruby 3.3, which is what I use in development.