Merged
Conversation
9fb1e3c to
5c988f8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2319 +/- ##
==========================================
+ Coverage 98.66% 98.68% +0.01%
==========================================
Files 205 205
Lines 13422 13486 +64
==========================================
+ Hits 13243 13308 +65
+ Misses 179 178 -1
|
Member
Author
|
rails CI is broken due to |
adinauer
approved these changes
Jun 7, 2024
| DELAYED_JOB_CONTEXT_KEY = :"Delayed-Job" | ||
| ACTIVE_JOB_CONTEXT_KEY = :"Active-Job" | ||
| OP_NAME = "queue.delayed_job".freeze | ||
| OP_NAME = "queue.delayed_job" |
Member
There was a problem hiding this comment.
Was .freeze removed from OP_NAME on purpose?
Member
Author
There was a problem hiding this comment.
some files have this on top so it applies to all strings by default
https://docs.ruby-lang.org/en/3.0/syntax/comments_rdoc.html#label-frozen_string_literal+Directive
I'll clean this up separately, just syntax nicety and it's not consistent in some files.
| ACTIVE_JOB_CONTEXT_KEY = :"Active-Job" | ||
| OP_NAME = "queue.delayed_job".freeze | ||
| OP_NAME = "queue.delayed_job" | ||
| SPAN_ORIGIN = "auto.queue.delayed_job" |
Member
There was a problem hiding this comment.
Not all of the span origins have the .freeze call, should they?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:originattribute to span and use in trace context and span hashcloses #2068