Merged
Conversation
Contributor
Author
|
@sl0thentr0py I'm not sure who to tag for a review but wanted to get some eyes on this since it's blocking our upgrade to sentry 1.17 |
sl0thentr0py
approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2317 +/- ##
==========================================
- Coverage 98.66% 97.09% -1.57%
==========================================
Files 205 175 -30
Lines 13422 11756 -1666
==========================================
- Hits 13243 11415 -1828
- Misses 179 341 +162
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comment
Description
Describe your changes:
this pr creates a copy instead of mutating the original, which fixes the issue and my company's test suite