Skip to content

Record :network_error client reports for send_envelope#2295

Merged
sl0thentr0py merged 2 commits intomasterfrom
neel/metrics-client-reports
Apr 11, 2024
Merged

Record :network_error client reports for send_envelope#2295
sl0thentr0py merged 2 commits intomasterfrom
neel/metrics-client-reports

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

No description provided.

Base automatically changed from neel/data-category-unify to master April 11, 2024 14:21
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2024

Codecov Report

Merging #2295 (a9e2cf4) into master (0257494) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2295   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         200      200           
  Lines       13241    13253   +12     
=======================================
+ Hits        13070    13082   +12     
  Misses        171      171           
Components Coverage Δ
sentry-ruby 99.09% <100.00%> (+0.01%) ⬆️
sentry-rails 97.33% <ø> (ø)
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 96.76% <ø> (-0.33%) ⬇️
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/client_spec.rb 96.27% <100.00%> (+0.08%) ⬆️

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/metrics-client-reports branch from de0ba71 to a9e2cf4 Compare April 11, 2024 14:23
@sl0thentr0py sl0thentr0py changed the title Record :network_error client reports for send_envelope Record :network_error client reports for send_envelope Apr 11, 2024
@sl0thentr0py sl0thentr0py merged commit 377cbdd into master Apr 11, 2024
@sl0thentr0py sl0thentr0py deleted the neel/metrics-client-reports branch April 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants