Add mechanism interface and default to handled false in integrations#2280
Merged
sl0thentr0py merged 2 commits intomasterfrom Apr 3, 2024
Merged
Add mechanism interface and default to handled false in integrations#2280sl0thentr0py merged 2 commits intomasterfrom
sl0thentr0py merged 2 commits intomasterfrom
Conversation
569db7b to
fe0ed81
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 97.61% 97.57% -0.04%
==========================================
Files 112 113 +1
Lines 4154 4170 +16
==========================================
+ Hits 4055 4069 +14
- Misses 99 101 +2
|
776afb7 to
6b3bee0
Compare
st0012
reviewed
Mar 27, 2024
| @module = exception.class.to_s.split('::')[0...-1].join('::') | ||
| @thread_id = Thread.current.object_id | ||
| @stacktrace = stacktrace | ||
| @mechanism = mechanism || Mechanism.new |
Contributor
There was a problem hiding this comment.
Can we move this default assignment upstream? I think if we assign a default in Hub#capture_exception as well, then we can just assume mechanism will always be present when it reached client and interfaces?
Member
Author
There was a problem hiding this comment.
I moved it to Client#event_from_exception since we'll have to break the signature of that method otherwise since it uses positional and not keyword arguments.
st0012
reviewed
Mar 27, 2024
6b3bee0 to
5eb6f42
Compare
st0012
reviewed
Mar 29, 2024
Contributor
st0012
left a comment
There was a problem hiding this comment.
Just one comment left, otherwise it's good.
4e46fc1 to
9130bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1743