Fix: Get connection from connection_pool instead of ActiveRecord::Base.connection#2278
Merged
sl0thentr0py merged 2 commits intogetsentry:masterfrom Mar 20, 2024
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2278 +/- ##
==========================================
+ Coverage 97.61% 97.64% +0.02%
==========================================
Files 112 112
Lines 4155 4154 -1
==========================================
Hits 4056 4056
+ Misses 99 98 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When attempting to retrieve a connection in
ActiveRecordSubscriber, a loop occurs, eventually leading toActiveRecord::ConnectionTimeoutError.In versions of Rails lower than 6, since the payload does not contain a connection, it tries to use
ActiveRecord::Base.connectionto get the current connection. However, it seems that this causessubscribe!to be called again.I am not sure if this issue is specific to MySQL. Please refer to the following repository for a reproduction environment:
https://github.com/Iwaide/re_app_for_sentry/
Fix
I have modified the code to search for and retrieve a connection from
ActiveRecord::Base.connection_pool.connections.I am not very familiar with connection management, so I am not entirely confident that this is the appropriate approach. Please make any necessary corrections.