Skip to content

Add Sentry::Metrics.timing API to measure blocks#2254

Merged
sl0thentr0py merged 19 commits intomasterfrom
neel/metrics/timing
Mar 12, 2024
Merged

Add Sentry::Metrics.timing API to measure blocks#2254
sl0thentr0py merged 19 commits intomasterfrom
neel/metrics/timing

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented Mar 4, 2024

part of #2246

@sl0thentr0py sl0thentr0py requested a review from st0012 March 4, 2024 14:58
@sl0thentr0py sl0thentr0py mentioned this pull request Mar 4, 2024
@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/timing branch from 40987d1 to 17a6cae Compare March 4, 2024 14:59
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2024

Codecov Report

Merging #2254 (7567daa) into master (d13923b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files         110      111       +1     
  Lines        4026     4060      +34     
==========================================
+ Hits         3926     3959      +33     
- Misses        100      101       +1     
Components Coverage Δ
sentry-ruby 98.21% <100.00%> (+0.02%) ⬆️
sentry-rails 95.05% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 90.76% <ø> (-1.54%) ⬇️
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/metrics.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/metrics/timing.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/timing branch 2 times, most recently from ee6ff18 to 175cde3 Compare March 4, 2024 15:15
@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/timing branch from 175cde3 to 8b438e8 Compare March 5, 2024 13:20
@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/timing branch from 8b438e8 to 094e4aa Compare March 5, 2024 15:26
Copy link
Copy Markdown
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question, see below!

Base automatically changed from neel/metrics-base to master March 12, 2024 12:52
@sl0thentr0py sl0thentr0py merged commit cf8f7ae into master Mar 12, 2024
@sl0thentr0py sl0thentr0py deleted the neel/metrics/timing branch March 12, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants