Test sentry-resque without Rails, fix constantize issue#2248
Merged
st0012 merged 4 commits intogetsentry:masterfrom Feb 20, 2024
Merged
Test sentry-resque without Rails, fix constantize issue#2248st0012 merged 4 commits intogetsentry:masterfrom
constantize issue#2248st0012 merged 4 commits intogetsentry:masterfrom
Conversation
You probably don't want the tests to use the same Redis you use for any
app development.
Maybe you want to use Docker with custom port:
docker run --rm -it -p 16379:6379 redis:6
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2248 +/- ##
===========================================
- Coverage 97.46% 66.44% -31.02%
===========================================
Files 102 101 -1
Lines 3825 3797 -28
===========================================
- Hits 3728 2523 -1205
- Misses 97 1274 +1177
|
Tests and fixes getsentry#2243
a059a93 to
81159ad
Compare
I think ruby/psych#655 was resolved long ago
dentarg
commented
Feb 17, 2024
Comment on lines
-11
to
-12
| # For https://github.com/ruby/psych/issues/655 | ||
| gem "psych", "5.1.0" |
Contributor
Author
There was a problem hiding this comment.
This makes tests pass on Ruby 2.4 (fail log before this change)
st0012
reviewed
Feb 18, 2024
Contributor
st0012
left a comment
There was a problem hiding this comment.
Thanks for the fix 👍
Would you mind updating the changelog too?
Contributor
Author
|
What do you want it to say? |
Contributor
|
Something like: - Fix undefined method `constantize' issue in sentry-resque ([#2248](https://github.com/getsentry/sentry-ruby/pull/2248)) |
Contributor
Author
|
Added to the changelog ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2243