Skip to content

Only instantiate SessionFlusher when the SDK is enabled under the current env#2245

Merged
st0012 merged 2 commits intomasterfrom
fix-#2234
Feb 10, 2024
Merged

Only instantiate SessionFlusher when the SDK is enabled under the current env#2245
st0012 merged 2 commits intomasterfrom
fix-#2234

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Feb 10, 2024

This method aims to encapsulate the conditions we need to consider for enabling session tracking. Currently, it includes:

  • Whether the auto_session_tracking option is enabled
  • Whether the SDK is enabled under the current environment

Closes #2234

This method aims to encapsulate the conditions we need to consider for
enabling session tracking. Currently, it includes:
- Whether the auto_session_tracking option is enabled
- Whether the SDK is enabled under the current environment
@st0012 st0012 changed the title Add Configuration#session_tracking Only instantiate SessionFlusher when the SDK is enabled under the current env Feb 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2024

Codecov Report

Merging #2245 (1aaaa60) into master (2979e86) will increase coverage by 30.97%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2245       +/-   ##
===========================================
+ Coverage   66.46%   97.43%   +30.97%     
===========================================
  Files         101      102        +1     
  Lines        3793     3825       +32     
===========================================
+ Hits         2521     3727     +1206     
+ Misses       1272       98     -1174     
Components Coverage Δ
sentry-ruby 98.14% <100.00%> (+42.53%) ⬆️
sentry-rails 95.05% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.06% <ø> (-1.59%) ⬇️
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.44% <100.00%> (+32.48%) ⬆️
sentry-ruby/lib/sentry/configuration.rb 98.79% <100.00%> (+19.52%) ⬆️

... and 53 files with indirect coverage changes

@st0012 st0012 requested a review from sl0thentr0py February 10, 2024 15:43
@st0012 st0012 merged commit 1d80548 into master Feb 10, 2024
@st0012 st0012 deleted the fix-#2234 branch February 10, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SessionFlusher ignores enabled_environments config

2 participants