Skip to content

Add hint: support to Sentry::Rails::ErrorSubscriber#2235

Merged
sl0thentr0py merged 2 commits intogetsentry:masterfrom
modosc:add-hints
Jan 17, 2024
Merged

Add hint: support to Sentry::Rails::ErrorSubscriber#2235
sl0thentr0py merged 2 commits intogetsentry:masterfrom
modosc:add-hints

Conversation

@modosc
Copy link
Copy Markdown
Contributor

@modosc modosc commented Jan 16, 2024 •
edited by sl0thentr0py
Loading

closes #2228

@modosc modosc mentioned this pull request Jan 16, 2024
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Merging #2235 (dc5d352) into master (bd4f58a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head dc5d352 differs from pull request most recent head e836902. Consider uploading reports for the commit e836902 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         102      102           
  Lines        3800     3804    +4     
=======================================
+ Hits         3702     3706    +4     
  Misses         98       98
Components Coverage Δ
sentry-ruby 98.13% <ø> (ø)
sentry-rails 95.05% <100.00%> (+0.03%) ⬆️
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-rails/lib/sentry/rails/error_subscriber.rb 100.00% <100.00%> (ø)

@sl0thentr0py sl0thentr0py changed the title Add hint: support to Sentry::Rails::ErrorSubscriber (fixes #2228) Add hint: support to Sentry::Rails::ErrorSubscriber Jan 17, 2024
sl0thentr0py
sl0thentr0py approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @modosc

@sl0thentr0py sl0thentr0py merged commit e811fe3 into getsentry:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add hint support to Sentry::Rails::ErrorSubscriber

2 participants

@modosc @sl0thentr0py