Add support for distributed tracing for DelayedJob#2233
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 97.39% 97.43% +0.03%
==========================================
Files 102 102
Lines 3804 3823 +19
==========================================
+ Hits 3705 3725 +20
+ Misses 99 98 -1
|
354e8fa to
534730d
Compare
st0012
left a comment
There was a problem hiding this comment.
Instead of injecting trace data to args, can we maybe use a custom ivar? Like @_sentry_trace_data. That way the extraction will be easier and we don't need to risk breaking the call completely if the args deletion somehow goes wrong.
we'll need to patch delayed_job's YAML stuff here then, since ivar's are not picked up by default and won't survive the database round trip. so I opted for this, which of the two do you prefer? |
Ah thanks for this context. Let's first go with the current implementation then. |
* only for `PerformableMethod` here, active job will be handled generally separately
Co-authored-by: Stan Lo <stan001212@gmail.com>
cfad4ab to
8485799
Compare
| @@ -1,4 +1,5 @@ | |||
| require "bundler/setup" | |||
| require "debug" if RUBY_VERSION.to_f >= 2.6 && RUBY_ENGINE == "ruby" | |||
| require "pry" | |||
There was a problem hiding this comment.
Not related: do you still use pry?
There was a problem hiding this comment.
nope! I've moved to debugger if available
PerformableMethodpart of #1904