Make sure sending_allowed? is respected irrespective of spotlight configuration#2231
Merged
sl0thentr0py merged 1 commit intomasterfrom Mar 13, 2024
Merged
Make sure sending_allowed? is respected irrespective of spotlight configuration#2231sl0thentr0py merged 1 commit intomasterfrom
sl0thentr0py merged 1 commit intomasterfrom
Conversation
sl0thentr0py
commented
Jan 15, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2231 +/- ##
===========================================
- Coverage 97.61% 64.58% -33.04%
===========================================
Files 112 111 -1
Lines 4153 4125 -28
===========================================
- Hits 4054 2664 -1390
- Misses 99 1461 +1362
|
st0012
reviewed
Jan 22, 2024
|
Just curious, is this something that will be merged soon? We've tried out Spotlight, but with this bug it's also caused all dev events to flow from developer machines to Sentry, with no easy way to turn it off. Would be great for us if this could be merged! |
42d4ce3 to
3206e27
Compare
3206e27 to
497a8e0
Compare
Member
Author
|
sorry slipped through the cracks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we need to make a difference between the 'event building' and the 'sending' so I made this more explicit.
fixes #2226