Merged
Conversation
0bb00f6 to
6de2cd4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
- Coverage 97.44% 97.42% -0.03%
==========================================
Files 102 102
Lines 3801 3801
==========================================
- Hits 3704 3703 -1
- Misses 97 98 +1
|
6de2cd4 to
c1b5e88
Compare
cleptric
approved these changes
Jan 9, 2024
Contributor
|
Is #2224 the craft upgrade needed to revert these changes? |
Member
Author
|
no if we need to revert this, we need to upgrade the ruby version of the github action (and possibly other things I haven't checked) |
Contributor
|
I see. I think changing this line should be enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2221
new sqlite3 release 1.7.0 dropped support for ruby < 3.0, so building
sentry-railsandsentry-delayed_jobfailed silently and only the rest were released by craft.#skip-changelog