Don't add most scope data to CheckInEvent#2217
Merged
sl0thentr0py merged 1 commit intomasterfrom Jan 8, 2024
Merged
Conversation
st0012
reviewed
Jan 7, 2024
Member
Author
we might introduce a couple back (like tags/extras), we're still iterating on the design, so I don't want to refactor too much. This was mainly to remove breadcrumbs because they caused payload bloat and caused missed check-ins. I removed the other stuff for now and we might back add some later. |
a218a32 to
74ae08c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 102 102
Lines 3800 3801 +1
=======================================
+ Hits 3702 3703 +1
Misses 98 98
|
st0012
approved these changes
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also removed the option to pass
&blockto the top levelSentry.capture_check_insince that would be useless now (pretty sure no one was using that anyway).closes #2191