Pick up config.cron.default_timezone from Rails config#2213
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2213 +/- ##
===========================================
+ Coverage 66.48% 97.38% +30.89%
===========================================
Files 100 102 +2
Lines 3742 3818 +76
===========================================
+ Hits 2488 3718 +1230
+ Misses 1254 100 -1154
|
1094b02 to
a2f945e
Compare
sl0thentr0py
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rails apps should have their timezone set, I think we can pick up
config.cron.default_timezonefrom it.