Skip to content

Fix keyword arguments for MonitorCheckIns monkeypatch#2199

Merged
sl0thentr0py merged 4 commits intomasterfrom
neel/fix-monitor-patch-opts
Dec 14, 2023
Merged

Fix keyword arguments for MonitorCheckIns monkeypatch#2199
sl0thentr0py merged 4 commits intomasterfrom
neel/fix-monitor-patch-opts

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented Dec 14, 2023

fixes #2198

#skip-changelog

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 14, 2023

Codecov Report

Merging #2199 (1c9cb52) into master (9895426) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
- Coverage   97.34%   97.32%   -0.03%     
==========================================
  Files         100      100              
  Lines        3734     3734              
==========================================
- Hits         3635     3634       -1     
- Misses         99      100       +1     
Components Coverage Δ
sentry-ruby 98.02% <100.00%> (-0.04%) ⬇️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.53% <ø> (ø)
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-monitor-patch-opts branch from 372eb93 to d1ad2a0 Compare December 14, 2023 14:40
@sl0thentr0py sl0thentr0py merged commit f12cc2c into master Dec 14, 2023
@sl0thentr0py sl0thentr0py deleted the neel/fix-monitor-patch-opts branch December 14, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry::Cron::MonitorCheckIns breaks ActiveJob keyword arguments

2 participants