Skip to content

Backpressure handling#2185

Merged
sl0thentr0py merged 3 commits intomasterfrom
neel/backrpressure
Dec 20, 2023
Merged

Backpressure handling#2185
sl0thentr0py merged 3 commits intomasterfrom
neel/backrpressure

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented Nov 29, 2023

closes #2063

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

Merging #2185 (7a3b48c) into master (0874ca8) will increase coverage by 5.45%.
The diff coverage is 98.46%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   91.90%   97.36%   +5.45%     
==========================================
  Files          81      101      +20     
  Lines        3238     3792     +554     
==========================================
+ Hits         2976     3692     +716     
+ Misses        262      100     -162
Components Coverage Δ
sentry-ruby 98.06% <98.46%> (+0.07%) ⬆️
sentry-rails 94.98% <ø> (+49.22%) ⬆️
sentry-sidekiq 94.53% <ø> (∅)
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (∅)
Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.42% <100.00%> (+0.57%) ⬆️
sentry-ruby/lib/sentry/background_worker.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.76% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/transaction.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/transport.rb 99.03% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/backpressure_monitor.rb 97.72% <97.72%> (ø)

... and 33 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/backrpressure branch 5 times, most recently from 981dc51 to 24a5283 Compare December 11, 2023 14:36
st0012
st0012 reviewed Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I know it's not fully ready for review yet, but overall looks good to me 👍)

@sl0thentr0py sl0thentr0py force-pushed the neel/backrpressure branch 4 times, most recently from 5f1f32a to 0330a26 Compare December 19, 2023 15:37
@sl0thentr0py sl0thentr0py marked this pull request as ready for review December 19, 2023 15:52
@sl0thentr0py sl0thentr0py requested a review from st0012 December 19, 2023 15:56
@cleptric cleptric self-requested a review December 19, 2023 15:57
@sl0thentr0py sl0thentr0py merged commit 7a6cc87 into master Dec 20, 2023
@sl0thentr0py sl0thentr0py deleted the neel/backrpressure branch December 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cleptric cleptric cleptric approved these changes

@st0012 st0012 Awaiting requested review from st0012

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Backpressure Management

3 participants

@sl0thentr0py @st0012 @cleptric