Correctly parse IPv6 addresses in Net::HTTP instrumentation#2180
Merged
st0012 merged 6 commits intogetsentry:masterfrom Nov 25, 2023
Merged
Correctly parse IPv6 addresses in Net::HTTP instrumentation#2180st0012 merged 6 commits intogetsentry:masterfrom
st0012 merged 6 commits intogetsentry:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2180 +/- ##
==========================================
+ Coverage 97.28% 97.31% +0.02%
==========================================
Files 99 99
Lines 3688 3690 +2
==========================================
+ Hits 3588 3591 +3
+ Misses 100 99 -1
|
Contributor
Author
|
Work in progress. Seems like older Rubies do not like |
st0012
approved these changes
Nov 25, 2023
Contributor
st0012
left a comment
There was a problem hiding this comment.
Thank you, it looks great 👍 I just have a nitpick on test.
st0012
reviewed
Nov 25, 2023
Co-authored-by: Stan Lo <stan001212@gmail.com>
st0012
reviewed
Nov 25, 2023
| # frozen_string_literal: true | ||
|
|
||
| require "net/http" | ||
| require "resolv" |
Contributor
There was a problem hiding this comment.
Could you add it to the net/http patch instead as it's required by it, not HTTPTransport.
Contributor
Author
There was a problem hiding this comment.
/facepalm my bad, one sec
Contributor
Author
|
@st0012, cleaned things up!
Let's see how CI gods feel about it. |
st0012
reviewed
Nov 25, 2023
Co-authored-by: Stan Lo <stan001212@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a
Net::HTTPinstrumentation fix forextract_request_infothat makes it parseIPv6addresses correctly.Fixes #2163.
Thank you @Rotario for reporting and suggesting a fix!
Changes