Avoid invoking ActiveSupport::BroadcastLogger if not defined#2169
Merged
st0012 merged 3 commits intogetsentry:masterfrom Nov 21, 2023
Merged
Avoid invoking ActiveSupport::BroadcastLogger if not defined#2169st0012 merged 3 commits intogetsentry:masterfrom
st0012 merged 3 commits intogetsentry:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
+ Coverage 97.30% 97.40% +0.09%
==========================================
Files 97 98 +1
Lines 3638 3655 +17
==========================================
+ Hits 3540 3560 +20
+ Misses 98 95 -3
|
st0012
approved these changes
Nov 21, 2023
Contributor
st0012
left a comment
There was a problem hiding this comment.
I wasn't aware the other loggers could also have braodcasts method too. Thanks for the fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
::ActiveSupport::BroadcastLoggeris not defined (Rails < 7.1) and::Rails.loggerinstance hasbroadcastsmethod defined, initialization of Sentry-ruby fails onNameError: uninitialized constant ActiveSupport::BroadcastLogger (NameError).I suggest changing the check to
::Rails.loggerbeing an instance of::ActiveSupport::BroadcastLogger(with adefined?check).