Skip to content

Enable opting out of patches#2151

Merged
sl0thentr0py merged 1 commit intomasterfrom
neel/patches-opt-out
Oct 30, 2023
Merged

Enable opting out of patches#2151
sl0thentr0py merged 1 commit intomasterfrom
neel/patches-opt-out

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented Oct 25, 2023 •
edited
Loading

closes #2095

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #2151 (efc4691) into master (2e51449) will increase coverage by 0.05%.
The diff coverage is 92.85%.

❗ Current head efc4691 differs from pull request most recent head 3f46bef. Consider uploading reports for the commit 3f46bef to get more accurate results

@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
+ Coverage   97.27%   97.33%   +0.05%     
==========================================
  Files          97       97              
  Lines        3634     3638       +4     
==========================================
+ Hits         3535     3541       +6     
+ Misses         99       97       -2
Components Coverage Δ
sentry-ruby 98.02% <92.85%> (+0.04%) ⬆️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 93.70% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.37% <100.00%> (+0.51%) ⬆️
sentry-ruby/lib/sentry/configuration.rb 98.73% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/net/http.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/puma.rb 92.30% <100.00%> (ø)
sentry-ruby/lib/sentry/redis.rb 96.22% <66.66%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/patches-opt-out branch 2 times, most recently from afcdaf6 to fa97407 Compare October 27, 2023 15:02
@sl0thentr0py sl0thentr0py marked this pull request as ready for review October 27, 2023 15:02
@sl0thentr0py sl0thentr0py requested a review from st0012 October 27, 2023 15:02
st0012
st0012 reviewed Oct 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it works well 👍 Just suggestions on tests.

@sl0thentr0py sl0thentr0py requested a review from st0012 October 30, 2023 13:39
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) October 30, 2023 13:43
st0012
st0012 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sl0thentr0py sl0thentr0py merged commit 1a74734 into master Oct 30, 2023
@sl0thentr0py sl0thentr0py deleted the neel/patches-opt-out branch October 30, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@st0012 st0012 st0012 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow opting out of patches

2 participants

@sl0thentr0py @st0012