Allow non-string error message to be reported to sentry#2137
Merged
st0012 merged 1 commit intogetsentry:masterfrom Nov 25, 2023
Merged
Allow non-string error message to be reported to sentry#2137st0012 merged 1 commit intogetsentry:masterfrom
st0012 merged 1 commit intogetsentry:masterfrom
Conversation
natikgadzhi
approved these changes
Nov 23, 2023
Contributor
natikgadzhi
left a comment
There was a problem hiding this comment.
Not related to the core team at Sentry, but the change looks reasonable to me. It's better to send out a longer, slightly awkward error message than to error out.
st0012
reviewed
Nov 23, 2023
d199675 to
5617ca3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 99 99
Lines 3687 3688 +1
=======================================
+ Hits 3589 3590 +1
Misses 98 98
|
st0012
approved these changes
Nov 24, 2023
Contributor
st0012
left a comment
There was a problem hiding this comment.
Thank you for the fix. Can you also add a changelog entry for it?
5617ca3 to
a5fa2ce
Compare
Contributor
Author
|
Thank you for the review! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #907 (comment)
Description
When the def message in the error class is overridden to return a non-string value. Sentry is not able to report the error due to the error
NoMethodError: undefined methodbyteslice' for []:Array`. Ideally, we shouldn't override the message and yet it was done 😓 .Describe your changes:
Convert non-string error message to string.