Skip to content

Adopt Rails 7.1's new BroadcastLogger#2120

Merged
st0012 merged 2 commits intomasterfrom
update-for-rails-7-1
Oct 2, 2023
Merged

Adopt Rails 7.1's new BroadcastLogger#2120
st0012 merged 2 commits intomasterfrom
update-for-rails-7-1

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Oct 1, 2023

In rails/rails#48615, Rails 7.1 introduced a new BroadcastLogger class that allows users to send logs to multiple loggers, which means we need to adjust the SDK's logger assignment for it.

@st0012 st0012 added this to the 5.11.0 milestone Oct 1, 2023
@st0012 st0012 self-assigned this Oct 1, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
sentry-rails/lib/sentry/rails/configuration.rb 96.87% <75.00%> (+3.77%) ⬆️

... and 23 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@st0012 st0012 force-pushed the update-for-rails-7-1 branch from 4150339 to 3e04c72 Compare October 1, 2023 11:20
st0012 added 2 commits October 1, 2023 12:56
In rails/rails#48615, Rails 7.1 introduced a new
BroadcastLogger class that allows users to send logs to multiple loggers,
which means we need to adjust the SDK's logger assignment for it.
@st0012 st0012 force-pushed the update-for-rails-7-1 branch from 3e04c72 to 821cb94 Compare October 1, 2023 11:56
@st0012 st0012 requested a review from sl0thentr0py October 1, 2023 12:00
@st0012 st0012 merged commit ab9fd5a into master Oct 2, 2023
@st0012 st0012 deleted the update-for-rails-7-1 branch October 2, 2023 12:07
@st0012
Copy link
Copy Markdown
Contributor Author

st0012 commented Oct 2, 2023

It turned out I also found a Rails issue when working on this 😄 rails/rails#49417 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants