Add new Sentry.capture_check_in API for Cron monitoring#2117
Add new Sentry.capture_check_in API for Cron monitoring#2117sl0thentr0py merged 1 commit intomasterfrom
Sentry.capture_check_in API for Cron monitoring#2117Conversation
Codecov Report
@@ Coverage Diff @@
## master #2117 +/- ##
==========================================
+ Coverage 97.41% 97.48% +0.06%
==========================================
Files 85 88 +3
Lines 3294 3382 +88
==========================================
+ Hits 3209 3297 +88
Misses 85 85
|
f48f9c1 to
1b0377e
Compare
1b0377e to
ef758e4
Compare
ef758e4 to
79abdbe
Compare
cleptric
left a comment
There was a problem hiding this comment.
Looks fine to me, I'm just worried about all the places CodeCov calls out as being uncovered.
|
codecov is off, just ignore it, a lot of those lines are covered |
79abdbe to
26557d8
Compare
|
Oh, and please get the codecove stuff fixed. You'll likely want to do something similar to https://github.com/getsentry/sentry/blob/master/codecov.yml#L61-L63. |
c2f266f to
045578a
Compare
* New `CheckInEvent` class for the envelope payload * New `Cron::MonitorConfig` class that holds the monitor configuration * New `Cron::MonitorSchedule` module that holds two types of schedules `Crontab` and `Interval`
045578a to
fb9bc77
Compare
|
CI will be fixed separately, codecov is now fixed so i'm merging |
| end | ||
|
|
||
| describe '.from_interval' do | ||
| it 'returns nil without valid unit' do |
There was a problem hiding this comment.
@sl0thentr0py would you consider having this raise instead? Maybe just in development/test?
I spent way too long trying to work out why this wasn't reporting properly:
There was a problem hiding this comment.
in general, as a principle, we don't raise in the Sentry SDK since we are an error monitoring service and we don't want to raise our own errors.
I could add debug logs if you wish.
There was a problem hiding this comment.
Haha yes that makes a lot of sense 😂
Logging would be amazing.
CheckInEventclass for the envelope payloadCron::MonitorConfigclass that holds the monitor configurationCron::MonitorSchedulemodule that holds two types of schedulesCrontabandIntervalpart of #2090