Conversation
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
sl0thentr0py
approved these changes
Sep 26, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2103
Currently,
TestHelpersets up / tears down tests by mutating the objects on the same layer. With this design, fixing #2103 would require storing the previous values of config and assigning them back after tests, which is error-prone.So in this PR, I decided to utilise the SDK's layer design in
setup_sentry_test:teardown_sentry_testis called, we can simply pop the layer from 2.If anything unexpected happens (e.g. users popped the stack themselves), having the base layer created in 1) will make sure no
NoMethodErrorwill be thrown or having any data being sent by accident.