Skip to content

Consolidate ActiveRecord and Redis database spans with Span::DataConventions#2100

Merged
sl0thentr0py merged 3 commits intomasterfrom
neel/starfish-db
Sep 5, 2023
Merged

Consolidate ActiveRecord and Redis database spans with Span::DataConventions#2100
sl0thentr0py merged 3 commits intomasterfrom
neel/starfish-db

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py commented Sep 4, 2023

closes #2088

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Patch coverage is 77.50% of modified lines.

❗ Current head 3be7f22 differs from pull request most recent head 4ab0076. Consider uploading reports for the commit 4ab0076 to get more accurate results

Files Changed Coverage
sentry-ruby/lib/sentry/net/http.rb 0.00%
...b/sentry/rails/tracing/active_record_subscriber.rb 66.66%
...rails/tracing/action_controller_subscriber_spec.rb 100.00%
...try/rails/tracing/active_record_subscriber_spec.rb 100.00%
sentry-rails/spec/sentry/rails/tracing_spec.rb 100.00%
sentry-ruby/lib/sentry/span.rb 100.00%

📢 Thoughts on this report? Let us know!.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review September 5, 2023 13:56
@sl0thentr0py sl0thentr0py requested a review from st0012 September 5, 2023 13:57
@cleptric cleptric self-requested a review September 5, 2023 13:59
@sl0thentr0py sl0thentr0py merged commit 6d67059 into master Sep 5, 2023
@sl0thentr0py sl0thentr0py deleted the neel/starfish-db branch September 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cleptric cleptric cleptric approved these changes

@st0012 st0012 Awaiting requested review from st0012

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Starfish] Add db attributes to database span's span data

2 participants

@sl0thentr0py @cleptric