Duplicate Rails.logger before assigning it to the SDK#2086
Merged
Conversation
If we don't duplicate it, logger configuration made to the SDK's logger will be applied to the Rails logger as well. For example, in an Rails app: ```rb Sentry.init do |config| config.logger.level = Logger::WARN end ``` Will make the Rails logger's level to be `Logger::WARN` as well.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2086 +/- ##
=======================================
Coverage 83.23% 83.23%
=======================================
Files 119 119
Lines 5671 5674 +3
=======================================
+ Hits 4720 4723 +3
Misses 951 951
☔ View full report in Codecov by Sentry. |
Closed
sl0thentr0py
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered this while investigating #2031: If we don't duplicate
Rails.logger, configurations made to the SDK's logger will be applied to the Rails logger as well.For example, in an Rails app:
Will make the Rails logger's level to be
Logger::WARNtoo. I think most users wouldn't expect this and will find it confusing.