Skip to content

Fix exception event sending failed#2083

Merged
st0012 merged 1 commit intogetsentry:masterfrom
yujideveloper:bugfix/exception-sending-failed-illegal-malformed-utf-8
Oct 1, 2023
Merged

Fix exception event sending failed#2083
st0012 merged 1 commit intogetsentry:masterfrom
yujideveloper:bugfix/exception-sending-failed-illegal-malformed-utf-8

Conversation

@yujideveloper
Copy link
Copy Markdown
Contributor

fixes #2082

@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch from cbb3869 to 8dec063 Compare August 2, 2023 12:32
@yujideveloper yujideveloper marked this pull request as ready for review August 2, 2023 12:33
@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch from 8dec063 to 2992cf9 Compare August 3, 2023 02:35
@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Sep 24, 2023

Sorry for the delay. I'm not sure why there's no triggerable CI runs on this PR. I also found a few expected failures when pulled the branch locally. Would you mind rebasing it against master and push again?

@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch from 2992cf9 to 6d16b25 Compare September 25, 2023 02:51
@yujideveloper
Copy link
Copy Markdown
Contributor Author

@st0012
Thank you for your reply. I rebased it against master.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...try-ruby/lib/sentry/interfaces/single_exception.rb 65.71% <50.00%> (ø)

... and 24 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch 3 times, most recently from f73015d to 96d8205 Compare September 27, 2023 05:42
@yujideveloper
Copy link
Copy Markdown
Contributor Author

I resolved confilict and fixed failing tests.

@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch from 96d8205 to bf8c61d Compare September 27, 2023 08:17
@yujideveloper
Copy link
Copy Markdown
Contributor Author

I missed a syntax error in Ruby 2.4 ...
I fixed it.

@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch from bf8c61d to f000758 Compare September 27, 2023 09:33
@yujideveloper
Copy link
Copy Markdown
Contributor Author

I improved test coverage.

This fixes `Event sending failed: source sequence is illegal/malformed utf-8`.
@yujideveloper yujideveloper force-pushed the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch from f000758 to b48724b Compare September 29, 2023 00:46
@yujideveloper
Copy link
Copy Markdown
Contributor Author

I resolved confilict.

Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@st0012
Copy link
Copy Markdown
Contributor

st0012 commented Oct 1, 2023

The tests failing are caused by latest Rails changes. I will fix them in a separate PR.

@st0012 st0012 merged commit 9f3567c into getsentry:master Oct 1, 2023
@st0012 st0012 added the bug fix label Oct 1, 2023
@st0012 st0012 added this to the 5.11.0 milestone Oct 1, 2023
@yujideveloper yujideveloper deleted the bugfix/exception-sending-failed-illegal-malformed-utf-8 branch October 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event sending failed: source sequence is illegal/malformed utf-8

2 participants