Skip to content

Fix uninitialized race condition in Redis integration#2057

Merged
sl0thentr0py merged 2 commits intomasterfrom
neel/fix-redis-race
Jun 21, 2023
Merged

Fix uninitialized race condition in Redis integration#2057
sl0thentr0py merged 2 commits intomasterfrom
neel/fix-redis-race

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

Fixes #2054

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-redis-race branch from 741078e to a487a90 Compare June 19, 2023 10:34
@sl0thentr0py sl0thentr0py requested a review from st0012 June 19, 2023 10:35
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (11ecd25) 83.20% compared to head (a487a90) 83.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2057      +/-   ##
==========================================
- Coverage   83.20%   83.18%   -0.02%     
==========================================
  Files         119      119              
  Lines        5661     5662       +1     
==========================================
  Hits         4710     4710              
- Misses        951      952       +1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/redis.rb 42.85% <0.00%> (-0.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012 st0012 added this to the 5.10.0 milestone Jun 21, 2023
Copy link
Copy Markdown
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sl0thentr0py sl0thentr0py merged commit 6196cec into master Jun 21, 2023
@sl0thentr0py sl0thentr0py deleted the neel/fix-redis-race branch June 21, 2023 10:03
@github-actions
Copy link
Copy Markdown

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix uninitialized race condition in Redis integration ([#2057](https://github.com/getsentry/sentry-ruby/pull/2057))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 39301d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Threading exception with Resque/Redis in exit

2 participants