Skip to content

Ignore low-level Puma exceptions by default#2055

Merged
st0012 merged 2 commits intomasterfrom
exclude-low-level-puma-exceptions
Jun 21, 2023
Merged

Ignore low-level Puma exceptions by default#2055
st0012 merged 2 commits intomasterfrom
exclude-low-level-puma-exceptions

Conversation

@st0012
Copy link
Copy Markdown
Contributor

@st0012 st0012 commented Jun 18, 2023

This is a follow-up to #2026. The idea is to ignore low-level Puma exceptions by default, but allow users to opt-in to capturing them.

Please see comments in #2026 for more details.

This is a follow-up to #2026. The idea is to ignore low-level Puma
exceptions by default, but allow users to opt-in to capturing them.

Please see comments in #2026
for more details.
@st0012 st0012 added the bug fix label Jun 18, 2023
@st0012 st0012 added this to the 5.10.0 milestone Jun 18, 2023
@st0012 st0012 self-assigned this Jun 18, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (11ecd25) 83.20% compared to head (e4d17eb) 83.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2055      +/-   ##
==========================================
+ Coverage   83.20%   83.25%   +0.05%     
==========================================
  Files         119      119              
  Lines        5661     5662       +1     
==========================================
+ Hits         4710     4714       +4     
+ Misses        951      948       -3     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 84.41% <100.00%> (+0.93%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012 st0012 merged commit 75aa456 into master Jun 21, 2023
@st0012 st0012 deleted the exclude-low-level-puma-exceptions branch June 21, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants