Conversation
0e5248d to
1da7359
Compare
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Tweak #2007 and add changelog for it ([#2023](https://github.com/getsentry/sentry-ruby/pull/2023))If none of the above apply, you can opt out of this check by adding |
1da7359 to
fd9a827
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2023 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 157 157
Lines 10110 10128 +18
=======================================
+ Hits 9965 9983 +18
Misses 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@sl0thentr0py Do you know how we should present such PRs in changelog 🤔 |
Member
|
ah we can just ignore danger for this, it's fine |
sl0thentr0py
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing a changelog entry for #2007, I found that the
ignore_exclusionswas added as a top-level option when usingSentry.capture_exception, which is not what was advised in #2006. I believe this is due to minor misunderstanding so I corrected it here.