Fix corner case when a value is integer#2000
Fix corner case when a value is integer#2000d1ys3nk0 wants to merge 1 commit intogetsentry:masterfrom d1ys3nk0:master
Conversation
|
@lysenkooo we expect the release to be a string throughout the SDK, this should be fixed at the source in |
We use this way: In that case app_build could be integer since it goes from In order to fix it now we started to use this: But we have spent a month to catch this. Because it was occuring only when app_build (which is first 7 chars from commit hash actually) was containing only digits. |
|
ok thanks, I'll modify the |
|
closing in favor of #2004 |
Thanks for your Pull Request 🎉
Please keep these instructions in mind so we can review it more efficiently:
Other Notes
Description
Describe your changes:
In edge case when I had parameter
releasecoming from my env containing all digits like9687411I ended up withTypeError: no implicit conversion of Integer into String. Today, finally we catched this bug.