Conversation
Codecov ReportBase: 98.62% // Head: 98.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1989 +/- ##
=======================================
Coverage 98.62% 98.63%
=======================================
Files 157 157
Lines 9970 10009 +39
=======================================
+ Hits 9833 9872 +39
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
85ab180 to
4e0180c
Compare
st0012
left a comment
There was a problem hiding this comment.
Just small comments on test.
| configuration.before_send_transaction = dbl | ||
|
|
||
| expect(dbl).not_to receive(:call) | ||
| subject.send_event(event) |
There was a problem hiding this comment.
Can we avoid using double/mocking when it's not too hard to test it end-to-end? In my experience taking over the old SDK it makes things hard to maintain in the long-term.
There was a problem hiding this comment.
I did this because of the new codecov enforcing (which was turned on org-wide on github), it was complaining about a test line not being run. I will generally not use doubles, but in this case it makes sense.
4e0180c to
64bf1f7
Compare
antonpirker
left a comment
There was a problem hiding this comment.
Now I know what virtual attributes and doubles are in Ruby
st0012
left a comment
There was a problem hiding this comment.
Sorry for the delay. I was on a trip recently.
I still wonder why that line can't be tested and detected without double, but it's not a blocker for this feature so I'll check it later.
resolves #1937