Span#with_child_span should finish the span even with exception raised#1982
Merged
Span#with_child_span should finish the span even with exception raised#1982
Span#with_child_span should finish the span even with exception raised#1982Conversation
This saves users from doing complicated exception handling logic inside
their operation block to save the span data, such as
```rb
span.with_child_span do |child_span|
begin
do_something
rescue
child_span.finish
raise
end
end
```
Codecov ReportBase: 98.62% // Head: 98.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1982 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 157 157
Lines 9870 9881 +11
=======================================
+ Hits 9734 9745 +11
Misses 136 136
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sl0thentr0py
approved these changes
Jan 9, 2023
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
yep, this matches python behaviour now since there it's a context manager which automatically does the rescue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves users from doing complicated exception handling logic inside their operation block to save the span data, such as
Now users only need:
I consider this a bug fix because I thought it's already working this way 😅