Add Sentry.add_global_event_processor API#1976
Merged
sl0thentr0py merged 1 commit intomasterfrom Jan 9, 2023
Merged
Conversation
Codecov ReportBase: 98.61% // Head: 98.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 157 157
Lines 9880 9911 +31
=======================================
+ Hits 9743 9774 +31
Misses 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
st0012
reviewed
Jan 7, 2023
Contributor
st0012
left a comment
There was a problem hiding this comment.
Generally looks good 👍 But it'd be better if we don't use class variable for it.
1b83757 to
176a842
Compare
176a842 to
9c16bb2
Compare
st0012
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other SDKs allow adding global event processors without configuring scope, so this adds the same functionality.
closes #1974
(need it to implement #1975)