Return value from 'perform_action' when initialized#1966
Merged
st0012 merged 3 commits intogetsentry:masterfrom Dec 30, 2022
Merged
Return value from 'perform_action' when initialized#1966st0012 merged 3 commits intogetsentry:masterfrom
st0012 merged 3 commits intogetsentry:masterfrom
Conversation
Codecov ReportBase: 98.04% // Head: 96.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1966 +/- ##
==========================================
- Coverage 98.04% 96.71% -1.34%
==========================================
Files 157 129 -28
Lines 9826 8422 -1404
==========================================
- Hits 9634 8145 -1489
- Misses 192 277 +85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
st0012
approved these changes
Dec 30, 2022
Contributor
st0012
left a comment
There was a problem hiding this comment.
Thanks for the fix, just 2 small comments 👍
Contributor
|
Rebasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
ActionCable::Channel::Base#perform_actionin our Action Cable testing and would like to use its return value as part of those tests. At the minute, when the SDK is not initialized then this works OK, as the return value ofblock.callis immediately returned:sentry-ruby/sentry-rails/lib/sentry/rails/action_cable.rb
Line 9 in dce8ef0
However, if we initialize the SDK, then the return value is swallowed. This change ensures that the result of
block.callis returned in all situations, apart from when an error is raised in the block.